fix: bootstrap custom pull event handler from local repo - #1005
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1005 +/- ##
==========================================
+ Coverage 49.95% 50.47% +0.51%
==========================================
Files 23 23
Lines 3375 3394 +19
==========================================
+ Hits 1686 1713 +27
+ Misses 1689 1681 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
isc-dchui
approved these changes
Sep 9, 2026
| @@ -0,0 +1,99 @@ | |||
| /// Tests that a pull event handler living in the repository itself can be used | |||
| /// on an instance where it has not been loaded/compiled yet - see issue #1000. | |||
Collaborator
There was a problem hiding this comment.
Nit: I dislike having issue numbers around in the code base but you may differ in opionion
Collaborator
Author
There was a problem hiding this comment.
I have the same opionion.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1000
When changes are imported through a pull event handler and there's a custom pull event handler that has needs to be loaded/compiled, we now import it from the local repository / compile it. This fix makes it smoother to onboard a new instance with Import All. A side effect is that changes to a custom pull event handler will now be reflected immediately on pull.
Assumption: a custom pull event handler has no other dependencies in the repo. I think we shouldn't bother with any special handling around that case unless somebody requests it.
Testing
Unit test fully covers expected behavior (thanks Claude)
Checklist
mainbranch rebased or merged.git-webui/srchave matching changes ingit-webui/release)