Repository navigation
Conversation
isc-kiyer
left a comment
There was a problem hiding this comment.
@isc-dchui good catches! Just one issue to address
| ClassMethod DirectoriesOverlapPython( | ||
| first As %String, | ||
| second As %String) As %Boolean [ Language = python ] | ||
| ClassMethod DirectoryContainsPython( |
There was a problem hiding this comment.
We should allow directory comparisons (pretty key) to work without embedded python. Oras should be the only part of IPM which requires embedded python to work.
Can we add a unit test for this to limit usage of Language = python to specific classes so we don't accidentally introduce this incompatibility?
There was a problem hiding this comment.
I am fine with having this if it gives a large performance boost but should fallback to ObjectScript only implementation
There was a problem hiding this comment.
@isc-kiyer There is already objectscript fallback code: see DirectoryContains(). The main benefit here is actually correctness, as I'm not aware of good objectscript ways to detect aliases, e.g. symlinks or bind mounts. (There are ugly ways like writing temp files when traversing directories and checking them, but I'm not sure if that's worth it.)
Description
Follow-up to two 0.10.11 PRs, from reviewing them together. #1311 (#300) keeps
FileCopyandCSPApplicationfrom clearing or deleting system directories, and #1316 (#934) refuses copies whose source and target overlap. Two gaps remain.CSPApplicationwith noDeployPathserves its resource folder in place, and aFileCopycan target its own source through a symlink or bind mount. A dev-mode uninstall of either deleted that folder from the repo. Uninstall now leaves any target that overlaps the source in place.Overlay="1"copies into{$installDir}or{$dataDir}, which worked in 0.10.10. Copies are now refused only when they could delete the source:Overlay="1"or a protected directory)Testing
New cases in
Test.PM.Integration.CopyDirOverlapandTest.PM.Integration.FileCopy, also run on IRIS 2026.1 for Windows.Checklist
mainbranch rebased or merged.zpm test -only) and integration tests (zpm verify -only) pass.🤖 Generated with Claude Code