Repository navigation
Conversation
isc-jili
left a comment
There was a problem hiding this comment.
@isc-eneil looks good! Left a few comments.
One more thing is I'm not sure about the way some names have been shortened; eg. AllRes VS AllResources, Msgs VS Messages. I would favor just having the full names to be clear but it's up to you!
isc-jlechtne
left a comment
There was a problem hiding this comment.
Looking good overall! Only additional comment is to +`1 Jacqueline's on turning the new try-catches into a macro that can be condensed back into one line.
isc-cborbonm
left a comment
There was a problem hiding this comment.
nothing I noted aside from Jacqueline's suggestion for a macro to replace try/catch blocks which sounds great. rest looks good to me!
isc-jili
left a comment
There was a problem hiding this comment.
Approving with the assumption that the macro we discussed will be implemented (if not too heavy of a lift)!
af24787
ba504ea
f2f40d8 to
ba504ea
Compare
No description provided.