Skip to content

Capture system-call output and add comprehensive redirection error handling - #1330

Open
isc-eneil wants to merge 5 commits into
logging-frameworkfrom
split/redirect-wrappers
Open

isc-eneil wants to merge 5 commits into
logging-frameworkfrom
split/redirect-wrappers

Conversation

@isc-eneil

Copy link
Copy Markdown
Collaborator

No description provided.

@isc-jili isc-jili left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isc-eneil looks good! Left a few comments.
One more thing is I'm not sure about the way some names have been shortened; eg. AllRes VS AllResources, Msgs VS Messages. I would favor just having the full names to be clear but it's up to you!

Comment thread src/cls/IPM/Lifecycle/Base.cls Resolved

@isc-jlechtne isc-jlechtne left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall! Only additional comment is to +`1 Jacqueline's on turning the new try-catches into a macro that can be condensed back into one line.

isc-cborbonm
isc-cborbonm previously approved these changes Nov 18, 2026

@isc-cborbonm isc-cborbonm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing I noted aside from Jacqueline's suggestion for a macro to replace try/catch blocks which sounds great. rest looks good to me!

isc-jili
isc-jili previously approved these changes Nov 18, 2026

@isc-jili isc-jili left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the assumption that the macro we discussed will be implemented (if not too heavy of a lift)!

@isc-eneil
isc-eneil dismissed stale reviews from isc-jili and isc-cborbonm via af24787 November 18, 2026 20:53
isc-jili
isc-jili previously approved these changes Nov 18, 2026
isc-cborbonm
isc-cborbonm previously approved these changes Nov 19, 2026
Comment thread src/cls/IPM/Main.cls Resolved
Comment thread src/cls/IPM/Main.cls Resolved
isc-jlechtne
isc-jlechtne previously approved these changes Nov 19, 2026
@isc-eneil
isc-eneil dismissed stale reviews from isc-jlechtne and isc-cborbonm via ba504ea November 19, 2026 21:20
@isc-eneil
isc-eneil force-pushed the split/redirect-wrappers branch from f2f40d8 to ba504ea Compare November 19, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants