Skip to content

Capture pip and CPF merge output to log files - #1331

Open
isc-eneil wants to merge 5 commits into
split/redirect-wrappersfrom
split/capture-pip-cpf-output
Open

isc-eneil wants to merge 5 commits into
split/redirect-wrappersfrom
split/capture-pip-cpf-output

Conversation

@isc-eneil

Copy link
Copy Markdown
Collaborator

No description provided.

@isc-eneil isc-eneil closed this Nov 17, 2026
@isc-eneil isc-eneil reopened this Nov 17, 2026
@isc-eneil
isc-eneil changed the base branch from main to logging-framework November 17, 2026 18:10
@isc-eneil
isc-eneil changed the base branch from logging-framework to split/redirect-wrappers November 17, 2026 18:13
@isc-eneil
isc-eneil added this pull request to stack #1332 November 17, 2026 18:13

@isc-jili isc-jili left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isc-eneil looks good! Left a few questions

Comment thread src/cls/IPM/ResourceProcessor/CPF.cls Resolved
Comment thread src/cls/IPM/ResourceProcessor/CPF.cls Resolved
@isc-eneil
isc-eneil requested a review from isc-jili November 17, 2026 20:23
Comment thread src/cls/IPM/ResourceProcessor/CPF.cls Outdated
set atEnd = ($zeof = -1)
use io // Switch back to the caller's original device so logging doesn't go to the command pipe
set line = $zstrip(line, "<>WC")
if (line '= "") {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the line is empty, I think we should still log it. Oftentimes it's there for a reason to help the readability of the plaintext logging

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, updating this.

@isc-cborbonm isc-cborbonm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question!

if $$$ISERR(sc) {
quit sc
}
set ..OriginalGlobals8KB = props("globals8kb")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this done both before and after each test?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sets the prior globals setting before running the tests and restores that globals setting after running the tests. The reason is that some of the CPF merge tests merge the following:

[config]
globals=0,0,150000,0,0,0

isc-jili
isc-jili previously approved these changes Nov 18, 2026

@isc-jili isc-jili left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

isc-cborbonm
isc-cborbonm previously approved these changes Nov 19, 2026
isc-jlechtne
isc-jlechtne previously approved these changes Nov 19, 2026
@isc-eneil
isc-eneil dismissed stale reviews from isc-jlechtne and isc-cborbonm via dfc9bbf November 19, 2026 21:20
@isc-eneil
isc-eneil force-pushed the split/capture-pip-cpf-output branch from 7df894a to dfc9bbf Compare November 19, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants