Skip to content

Vendor corrected TypeScript grammar for abstract and accessor members - #25

Merged
inth3shadows merged 2 commits into
mainfrom
grammar/fork-608a9db
Nov 8, 2026
Merged

inth3shadows merged 2 commits into
mainfrom
grammar/fork-608a9db

Conversation

@inth3shadows

@inth3shadows inth3shadows commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

TypeScript classes with members named abstract or accessor, and auto-accessor modifiers, now index correctly. Generic calls and typed tags using typeof abstract retain their call references; runtime typeof comparisons and optional chains retain their runtime meaning without phantom generic calls.

This updates both native C and wasm TypeScript/TSX grammars from fork 7dbdfae to the merged, reviewed source commit ed828ca (inth3shadows/tree-sitter-typescript#28). It refreshes the public reproducer patch, provenance/hash tables and baseline; mirrors the fork fixtures; and adds tree-shape plus raw-native/wasm extraction regressions for real query calls and runtime comparisons. The source correction closes the typeof abstract regression found in the first review of this PR.

Validation passed: kernel build, normal build, 83 focused grammar/parity/scaffold tests (including 19-language node/field parity and direct native extraction), full suite 11,132 passed / 2 expected failures / 61 skipped, strict local fixtures, exact source/artifact hashes and public patch roundtrip. Full differential: 14,612 files, 0 new / 0 worse. Two existing Effect divergences and four unrelated local gaps remain. The complete local gate ran against identical code/artifacts before the provenance pin was changed from reviewed head 780041c to its identical-tree merge ed828ca; the 83 focused tests were rerun after that documentation update.

Correction commit: be4a2d3. Both fresh consumer VERIFY round 2 reviewers returned no findings, with R1 and R2 closed. Broad verification covered 264 strict-valid cases, all fixture graph parity and provenance; adversarial verification covered 1,840 strict-valid cases per dialect. Direct native and forced-wasm extraction agreed, with no introduced loss of real calls or phantom calls. Latest-head TS grammar differential CI 42515894449 passed. Merged as 5e0664891af0e87e6fd18bbfa16cab39237570f5 after both fresh reviewers cleared the correction, latest-head CI passed, and completion/tracking was confirmed before merge. Deployed locally as v1.6.2-em.40 from merge 5e066489 on 2026-11-08. Both codegraph wrappers use the stable WASM-only installation; all 17 existing stable-repo indexes rebuilt successfully and passed strict status verification. Installed grammar/runtime hashes, TS/TSX extraction and live call-edge smokes passed. Retired 21 older MCP engine processes gracefully; existing MCP clients need to reconnect. Wrapper backups and deployment/health manifests are saved locally. No public npm/GitHub release or Git tag mutation was performed; the historical v1.6.2-em.40 tag still denotes the older commit, and the actual deployment is explicitly pinned to this merge.

@inth3shadows inth3shadows changed the title Vendor TypeScript fork 608a9db for abstract and accessor members Vendor corrected TypeScript grammar for abstract and accessor members Nov 8, 2026
@inth3shadows
inth3shadows marked this pull request as ready for review November 8, 2026 19:43
@inth3shadows
inth3shadows merged commit 5e06648 into main Nov 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant