Repository navigation
Vendor corrected TypeScript grammar for abstract and accessor members - #25
Merged
Merged
Conversation
inth3shadows
marked this pull request as draft
November 8, 2026 02:59
inth3shadows
marked this pull request as ready for review
November 8, 2026 19:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript classes with members named
abstractoraccessor, and auto-accessor modifiers, now index correctly. Generic calls and typed tags usingtypeof abstractretain their call references; runtimetypeofcomparisons and optional chains retain their runtime meaning without phantom generic calls.This updates both native C and wasm TypeScript/TSX grammars from fork
7dbdfaeto the merged, reviewed source commited828ca(inth3shadows/tree-sitter-typescript#28). It refreshes the public reproducer patch, provenance/hash tables and baseline; mirrors the fork fixtures; and adds tree-shape plus raw-native/wasm extraction regressions for real query calls and runtime comparisons. The source correction closes thetypeof abstractregression found in the first review of this PR.Validation passed: kernel build, normal build, 83 focused grammar/parity/scaffold tests (including 19-language node/field parity and direct native extraction), full suite 11,132 passed / 2 expected failures / 61 skipped, strict local fixtures, exact source/artifact hashes and public patch roundtrip. Full differential: 14,612 files, 0 new / 0 worse. Two existing Effect divergences and four unrelated local gaps remain. The complete local gate ran against identical code/artifacts before the provenance pin was changed from reviewed head
780041cto its identical-tree mergeed828ca; the 83 focused tests were rerun after that documentation update.Correction commit:
be4a2d3. Both fresh consumer VERIFY round 2 reviewers returned no findings, with R1 and R2 closed. Broad verification covered 264 strict-valid cases, all fixture graph parity and provenance; adversarial verification covered 1,840 strict-valid cases per dialect. Direct native and forced-wasm extraction agreed, with no introduced loss of real calls or phantom calls. Latest-head TS grammar differential CI 42515894449 passed. Merged as5e0664891af0e87e6fd18bbfa16cab39237570f5after both fresh reviewers cleared the correction, latest-head CI passed, and completion/tracking was confirmed before merge. Deployed locally asv1.6.2-em.40from merge5e066489on 2026-11-08. Both codegraph wrappers use the stable WASM-only installation; all 17 existing stable-repo indexes rebuilt successfully and passed strict status verification. Installed grammar/runtime hashes, TS/TSX extraction and live call-edge smokes passed. Retired 21 older MCP engine processes gracefully; existing MCP clients need to reconnect. Wrapper backups and deployment/health manifests are saved locally. No public npm/GitHub release or Git tag mutation was performed; the historicalv1.6.2-em.40tag still denotes the older commit, and the actual deployment is explicitly pinned to this merge.