Repository navigation
fix: prevent unrelated CommonJS member call targets - #28
Draft
inth3shadows wants to merge 3 commits into
Draft
inth3shadows wants to merge 3 commits into
inth3shadows wants to merge 3 commits into
Conversation
Track imported export files during sync, retain callable export aliases, and require block visibility for local class shadows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommonJS default-binding member calls could resolve to an unrelated class when the imported module does not export that member. This change adds the namespace guard, sync dependency tracking, scope checks, and an isolated tokenizer-based export reader while preserving explicitly exported callable aliases.
Draft checkpoint of the current work. Do not merge by itself: known review finding F8 mistakes wrap(eval)("ignored") for grouped direct eval, which can restore a decoy call for a missing member. The separate correction is #29, based on this branch; review and integrate that follow-up before considering this PR for main.
Validation on this checkpoint: 91 focused tests and npm run build passed. The pre-final-eval full suite passed 10,650 tests (2 expected failures, 448 skips), predating the last eval adjustment. The final checkpoint full run was deliberately interrupted after review demonstrated F8. Both native review lanes completed; the intended eval cases passed, but the broad lane reproduced F8. Final combined verification is tracked in #29.
Refs #27. No deployment or upstream report is included.