Repository navigation
fix(queue): carry a rounded duration into the next unit - #10086
Merged
Merged
Conversation
59.996s showed as 60.00s and 119.6s as 1m 60s in the queue duration label. Rounding now happens before the unit split.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
joshistoast
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The queue's duration label (queue rows and item details) rounds after it picks a unit, so a value that rounds up to the next unit prints an impossible label:
60.00s1m 0s1m 60s2m 0s59m 60s1h 0mformatDurationnow checks the two-decimal label against 60 and rounds to whole seconds before splitting minutes and hours, the same approachformatDurationinworkbench/image-map/indexProgress.tsalready takes.Related Issues / Discussions
None.
QA Instructions
src/features/queue/ui/formatDuration.test.tscovers ordinary seconds/minutes/hours, the three carry cases above, and the null cases. The carry case fails onmain(expected '60.00s' to be '1m 0s') and passes with this change.oxfmt --checkandoxlinton the two changed files pass. I ran the test with vitest outside a fullpnpm install, sopnpm lintandpnpm test:allwere not run locally.Review
Self-reviewed; small pure function change with no UI layout change. No material findings.
Checklist
What's Newcopy (if doing a release after this PR)This PR was prepared with AI assistance; I reviewed the change and ran the tests above.
Need help on this PR? Tag
@codesmith-botwith what you need.