Repository navigation
Conversation
The layer menu gains Layer properties, which opens the Properties tab and scrolls it to the Layer section below the tool settings. The Canvas user guide points to it instead of the scroll workaround.
github-actions
Bot
added
frontend
joshistoast
left a comment
joshistoast
left a comment
There was a problem hiding this comment.
I like this addition, a few issues to resolve first though
| const handleOpenProperties = useCallback(() => { | ||
| revealProperties(layer.id); | ||
| focusRegion('right', 'layers'); | ||
| revealLayerSection(); |
There was a problem hiding this comment.
[P2] Layer properties can show the child’s settings instead.
Select a regional reference image, mask modifier, or raster adjustment; then right-click its parent and choose Layer properties. The parent is already selected, and this action never clears child selection. The pane therefore retains the child editor—for example, reference-image controls instead of regional prompts. Clear child selection in this action and test that transition.
| if (section) { | ||
| section.scrollIntoView({ block: 'nearest' }); |
There was a problem hiding this comment.
[P2] The shortcut can leave the section’s initial controls offscreen.
After scrolling down within a tall Layer section, choosing Layer properties may do nothing: block: 'nearest' preserves the position when the section spans the viewport. Its heading and prompts remain above view. Align the section’s start or target its heading, and test repeated navigation. I confirmed this behavior in an isolated Chromium reproduction.
…e section start Layer properties now clears a selected child row of the layer (reference image, mask modifier, adjustment), so the pane shows the layer's own settings. The reveal aligns the Layer section's start instead of 'nearest', which left a tall section untouched after the user had scrolled down within it. Browser tests cover both transitions, including a repeated reveal.
|
Thanks @joshistoast, good catches! Both are fixed: Layer properties now clears the child selection, and the reveal aligns to the section start so it works after scrolling too. Added a browser test for each. |
Summary
A new Regional guidance or Control layer looks like it has no settings: its prompts and control model are in the Properties tab's Layer section, which sits below the tool settings and starts out of view. The layer menu now has Layer properties. It selects the layer, opens the Properties tab and scrolls the pane to the Layer section. It uses the existing
openPropertieseffect, which no menu action called since the per-row Properties button was retired.The scroll is only for this menu item. Filter and Select Object are unchanged; they do not scroll the pane. The Canvas user guide now points to the item instead of the scroll workaround.
Related Issues / Discussions
Closes #9617
QA Instructions
pnpm dev:mock, open Edit on canvas.Checked the same way at 1366×768 from the Transform tab, and on a non-selected inpaint mask (the menu selects it and shows its settings).
The video shows a Regional guidance layer added, its settings out of view, then Layer properties from its right-click menu bringing them into view.
invokeai.mp4
It is an automated browser run, so the cursor is drawn on top.
Checks:
pnpm lint: passes.pnpm test src/workbench/widgets/layers: 358 passed.pnpm test:browser src/workbench/widgets/layers: 239 passed. The newLayerEditorPanescase fails without the scroll.Not run: the full
pnpm check:release(performance, project-file and accessibility journeys).Review
No material findings. The menu screenshot in the Layers panel guide predates the new item and is not updated here.
Checklist
What's Newcopy (if doing a release after this PR)Fix written with Claude Code; video is an automated browser run of this branch recorded by User Stories Bot.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.