Repository navigation
test(recall): fail when a recorded metadata key has no recall contract - #10220
Open
Pfannkuchensack wants to merge 5 commits into
Open
Pfannkuchensack wants to merge 5 commits into
Pfannkuchensack wants to merge 5 commits into
Conversation
Image and video recall contracts classify every key the graph builders record and prove each round trip. Recall now restores PiD mode and steps, and the target resolution of media-sized video canvases. The checks workflow also runs when the generated API types change.
Pfannkuchensack
requested review from
blessedcoolant,
joshistoast and
lstein
as code owners
November 9, 2026 22:46
joshistoast
requested changes
Nov 9, 2026
The recorded canvas is snapped, so its ratio cannot stand in for the media; the executor now resolves the target resolution once the media are hydrated.
joshistoast
approved these changes
Nov 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nothing checked that metadata recall reads what the graph builders record, so recall gaps were found by hand (#10169, #10140). Every key an image or video graph records now needs an entry in a recall contract, and a key without one fails the frontend tests.
imageRecallContract.test.tsandvideoRecallContract.test.tscompile every Generate base and shape, Canvas modes, Upscale, hosted providers, and every video base, variant and mode. Each recallable setting is tuned off its default. The tests then check:CoreMetadataInvocationdeclares. A backend field added without an entry failstsc.frontend-checksnow also runs wheninvokeai/frontend/api/schema.tschanges, so this check runs on the backend PR that adds the field.videoTitles.sizenotice title.*.testing.tsfiles, unchanged. The remix and video round-trip tests the contracts replace are removed.Related Issues / Discussions
denoising_start,add_noise,tile_*, ...), which a frontend contract cannot see.QA Instructions
From
invokeai/frontend/webv2:pnpm lint pnpm test src/workbench/image-actions src/features/generation/core/graphCoverage.test.ts src/features/generation/core/canvas src/features/video/core src/features/upscale/core src/architecture/architectureWorkflow.test.ts src/platform/i18npnpm lintpasses. The focused run passes: 49 files, 2639 tests. The two contract files take under 1 s.clusterStats,indexProgressandmodelCacheStore, plus the AltGr test inkeys.test.ts.Review
No blocking findings. Remaining limits:
recallTunedSettingsFor; the docs say so.steps/cfg_scaleit does not use (bug: Ideogram 4 frontend generation saves unused steps/cfgScale in metadata and does not recall sampler preset or overrides #10140).Checklist
What's Newcopy (if doing a release after this PR)Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.