Repository navigation
Conversation
Store the T5, CLIP-L and CLIP-G overrides used by the SD 3 loader and restore compatible installed components on image recall.
Member
|
I don’t want to stop you from fixing bugs, but we’ve just discussed this as a team and would like to approach the matter in a more comprehensive way. Are you on discord so we can share our plan on that with you? |
Contributor
Author
|
Thanks for reaching out. I don't have Discord, but I'd be happy to discuss the team's plan. Do you use Telegram, or is there another platform where we could coordinate? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SD 3 images generated with separate text encoders lose those selections on recall. Canvas and Generate now save the T5, CLIP-L and CLIP-G overrides sent to the SD 3 loader. Recall all and Remix restore each compatible installed encoder, including when the same SD 3 model is already selected.
Related Issues / Discussions
Closes #9981
QA Instructions
pnpm check:releasepassed formatting, lint and TypeScript. At the unit stage, 13,238 tests passed and two macOS shortcut assertions failed, in shortcut hints and command palette entries. Both failures reproduce on clean upstream02e3ee0e5b. The later release stages did not run.Review
The SD 3 graph reads the encoder identifiers from the loader it just built. Recall uses the existing installed-model and slot checks. Older records without encoder fields retain their current compatible selections.
Checklist
What's Newcopy (if doing a release after this PR)Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.