Repository navigation
feat(models): preserve starter model source links - #10234
Open
joshistoast wants to merge 2 commits into
Open
joshistoast wants to merge 2 commits into
joshistoast wants to merge 2 commits into
Conversation
Add curated model-page links to starter rows and retain them through installation and re-identification. Display preserved sources in model details and regenerate API contracts.
Preserve model-page links on converted records and keep browser context menus available on starter links. Cover conversion persistence, row interactions, and deferred menu focus.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starter models now carry a
source_urlsarray of model-page links, separate from the download source. Rows offer Visit source for one link or a menu for multiple links. Installation preserves links for models and dependencies, and installed model details display them alongside legacysource_urlvalues without duplicates.Local starter catalog entries include their repository pages; selected FLUX entries include upstream pages too. Re-identification and conversion to Diffusers retain the links. Source-link right-clicks preserve native browser actions.
QA Instructions
pnpm check:releaseattempt hitConfirmDialog.browser.test.tsx(reconciles a confirmation closed while its Activity is hidden), also reproduced on unmodified main. CI is rerunning for the updated commit.To inspect: open Model Manager → Add Models. A model with one page opens directly; one with several opens a menu. Install a starter or bundle, then open model details and check the source links.
Review
Resolved metadata loss during checkpoint-to-Diffusers conversion and source links opening the enclosing row's install menu on right-click. Regression tests exercise the conversion route with the real installer and SQLite store, and source links inside real starter rows. Menu focus tests wait for deferred focus before Escape and cover pointer and keyboard opening. No material findings remain. Source links are metadata-only and do not invalidate loaded model caches.
Compatibility / Rollout
Additive API/config metadata; generated OpenAPI and TypeScript contracts updated. Older stored records default to an empty list without a database migration. Existing
sourceandsource_urlbehavior is retained. Existing installed records are not backfilled.Checklist
What's Newcopy (if doing a release after this PR)Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.