Repository navigation
fix(patchmatch): point build-failure guidance at current docs - #10235
Open
Shanmukh-l33t wants to merge 1 commit into
Open
Shanmukh-l33t wants to merge 1 commit into
Shanmukh-l33t wants to merge 1 commit into
Conversation
Drop pypatchmatch's stale installation-help record at its source logger and log the current documentation URL instead, keeping the compile error detail. The hard-coded URL in pypatchmatch 1.0.2 resolves to a 404 since the docs moved.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When pypatchmatch's C extension fails to build,
patchmatch.patch_matchlogs an installation-help URL that is hard-coded in pypatchmatch 1.0.2 and now resolves to a 404 (the docs page moved). Failed builds therefore pointed users at a dead link.PatchMatchnow drops only that stale guidance record at pypatchmatch's source logger (before the import that emits it) and logs the current installation help location instead. The compile error detail pypatchmatch reports is kept, and the success path is unchanged. A follow-up URL fix in PyPatchMatch would let the filter be removed.Related Issues / Discussions
Fixes #9775
QA Instructions
Reproduction of the issue's message on unmodified
main(pypatchmatch 1.0.2, forcedmakefailure):Same command on this branch:
The stale URL is gone from the output and the compile error detail survives.
uv run --no-sync pytest tests/backend/image_util/test_patchmatch.pyfails asserting the stale URL is not emitted — captured output containsRefer to https://invoke-ai.github.io/InvokeAI/installation/060_INSTALL_PATCHMATCH/ for installation instructions.2 passed.uv tool run ruff@0.11.2 checkandformat --checkon both changed paths: passed.Review
No material findings in self-review. The filter matches on the exact stale URL only, so any other pypatchmatch log record (including the compile error) passes through unchanged.
Checklist
What's Newcopy (if doing a release after this PR)Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.