Skip to content

test(hotkeys): honor platform-specific shortcut labels - #10237

Open
renningg wants to merge 1 commit into
invoke-ai:mainfrom
renningg:fix/macos-hotkey-test-expectations
Open

renningg wants to merge 1 commit into
invoke-ai:mainfrom
renningg:fix/macos-hotkey-test-expectations

Conversation

@renningg

@renningg renningg commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Two unit tests fail on macOS because their expected shortcut labels use the wrong modifier or order. The shortcut-hint assertion now expects the platform's label order, and the command-palette test exercises both macOS and other platforms with explicit expected values.

Related Issues / Discussions

The macOS baseline failures are also noted in #10226.

QA Instructions

  • On macOS, run pnpm test src/workbench/hotkeys/shortcutHints.test.ts src/workbench/palette/entries.test.ts. Clean main fails two assertions; this branch passes all 40 tests across the two files.
  • pnpm check:release passes formatting, lint, type checking and all 13,233 unit tests. The Chromium stage reports 4,619 passed, 51 failed and 1 skipped. The 12 failures in the command-palette and modal hotkey browser suites also reproduce on clean main. Later release stages did not run.

Review

The tests assert the public display values and retain the command-execution check. Shortcut bindings and application code are unchanged.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Meaningful regression coverage added / updated where needed; obsolete tests/code removed
  • Persisted-state and API changes include required migrations / compatibility validation
  • Relevant performance/efficiency opportunities considered; material claims have evidence
  • Material review findings resolved and relevant checks rerun
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Verify the modifier labels and their order on macOS and other platforms.
@github-actions github-actions Bot added the frontend PRs that change frontend files label Nov 11, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend PRs that change frontend files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant