Repository navigation
Conversation
Verify the modifier labels and their order on macOS and other platforms.
4 of 7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unit tests fail on macOS because their expected shortcut labels use the wrong modifier or order. The shortcut-hint assertion now expects the platform's label order, and the command-palette test exercises both macOS and other platforms with explicit expected values.
Related Issues / Discussions
The macOS baseline failures are also noted in #10226.
QA Instructions
pnpm test src/workbench/hotkeys/shortcutHints.test.ts src/workbench/palette/entries.test.ts. Cleanmainfails two assertions; this branch passes all 40 tests across the two files.pnpm check:releasepasses formatting, lint, type checking and all 13,233 unit tests. The Chromium stage reports 4,619 passed, 51 failed and 1 skipped. The 12 failures in the command-palette and modal hotkey browser suites also reproduce on cleanmain. Later release stages did not run.Review
The tests assert the public display values and retain the command-execution check. Shortcut bindings and application code are unchanged.
Checklist
What's Newcopy (if doing a release after this PR)Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.