chore(renovate): manage the root package.json and scope every rule - #4697
Open
thetaPC wants to merge 1 commit into
Open
chore(renovate): manage the root package.json and scope every rule#4697thetaPC wants to merge 1 commit into
thetaPC wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: internal
What is the current behavior?
Renovate's
includePathscovers onlystatic/code/stackblitz/**/*/package.jsonand.github/workflows/**, so the rootpackage.jsongets no dependency PRs at all. Every upgrade there is manual, which is howtypescriptcame to read^5.9.3while 5.3.3 was actually installed.What is the new behavior?
The root
package.jsonis in scope.Three rules were added for it, all at the end of
packageRules:docusaurusgroups the six@docusaurus/*packages, which sit at^3.10.2and must move togetherreact-rootcaps react and react-dom below 20.@docusaurus/coredeclares"react": "^18.0.0 || ^19.0.0"typescriptstays below 6, since@docusaurus/tsconfigsetsbaseUrl, which 6 deprecates and 7 removesEach names the Docusaurus constraint behind it, so they can be revisited together at v4.
Every rule now carries
matchFileNames. Four didn't, and they were all written when stackblitz was the only thing managed. Left alone,@ionic/**andreactwould have quietly started applying to the root: the first carries"minimumReleaseAge": "0 days"so Ionic releases reach the examples immediately, which would have let@ionic/prettier-configskip the repo's 3-day soak and land grouped with example bumps.That's the reason for the blanket rule rather than only fixing the two that bite. An unscoped rule widens on its own whenever a path is added to
includePaths.Does this introduce a breaking change?
Config only. Validated with
renovate-config-validator.Other information
The
docusaurusgroup is strictly redundant:config:recommendedextendsgroup:monorepos, and Docusaurus is in Renovate's monorepo data, so those packages would group anyway. Kept deliberately, because the rule documents the constraint rather than leaving it implicit in data we don't control.