Conversation
elinalin
marked this pull request as draft
September 22, 2026 09:10
Signed-off-by: I583364 <minmin.lin@sap.com>
- Support NAMESPACE env var so tests run in a dedicated namespace instead of always defaulting to "default" - Delete pre-existing objects in Create() to recover from interrupted runs - Increase timeout from 10s to 60s for real-device reconciliation - Add precondition check to BGP test cases (verify clean state before test) - Add bgp.txt combining test cases 4 and 5 into a single script Signed-off-by: I583364 <minmin.lin@sap.com>
Signed-off-by: I583364 <minmin.lin@sap.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test results
Test case 4 (default BGP create + delete): PASS — global `router bgp` instance and `operator-managed--default` marker fully removed after deletion.
Test case 5 (per-VRF BGP selective delete): documents a known bug in `deleteBGP` introduced in `1c03adb8`. After deleting both VRF-scoped BGP bricks, `router bgp 65000` and ownership markers remain on the device. Root cause: a post-deletion `GetConfig` reads stale state due to NX-OS's gNMI consistency window and incorrectly concludes a managed domain still exists. This test case is intentionally included to reproduce the bug — it is expected to fail until the bug is fixed separately.
Test plan