-
Notifications
You must be signed in to change notification settings - Fork 68
Feature: make the SCSS file importable without an improper path #244
Copy link
Copy link
Open
Labels
discussionIndicates that this issue / PR needs to be discussed in detail before further steps can be takenIndicates that this issue / PR needs to be discussed in detail before further steps can be takenneeds reproIndicates that this issue needs a reproduction before further steps can be takenIndicates that this issue needs a reproduction before further steps can be taken
Description
Activity
Metadata
Metadata
Assignees
Labels
discussionIndicates that this issue / PR needs to be discussed in detail before further steps can be takenIndicates that this issue / PR needs to be discussed in detail before further steps can be takenneeds reproIndicates that this issue needs a reproduction before further steps can be takenIndicates that this issue needs a reproduction before further steps can be taken
I want to import the SCSS file into my own SCSS file. This is only possible using the dirty path (including
../node_modules) as@use '../../node_modules/angular-notifier/styles.scss'and not using the short-hand version@use 'angular-notifier/styles', which is the way I can import styling files of other packages.I believe the problem here is that the styling file is called
styles.scss, but there is a folder namedstylesas well. This dirty import could be circumvented if either of the two would be renamed. I would suggest renaming the styles file todefault.scssfor example.This would of course be a breaking change.