Repository navigation
Conversation
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
itsdfish
reviewed
Oct 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been a set of issues I've found in the DDM that has been causing me some issues and this PR fixes many of the sharp edges I've found. There may be more, but I have found these changes make the model more robust.
DDM used to compute its density on the natural scale and then take
log(pdf(...)). For small boundary separations, very short or very long RTs, or large drift rates, the density underflowed to 0. That producedlogpdf = -InfwithNaNgradients, which breaks HMC/NUTS in Turing.logpdfalso threw anArgumentErrorforrt ≤ τ, which aborts sampling instead of rejecting the proposal.This PR computes
logpdfdirectly in log space and definespdfasexp(logpdf).cc: @PTWaade