Stabilize CI: deterministic TestIssue1773, Xvfb retry hardening, Maven 429 backoff - #2953
Merged
Merged
Conversation
…emitter Reseed the shared FastMath.rand to a fixed value at the start of each parameterized invocation so particle positions are reproducible, and remove the MotionEvent-driven moving emitter (which caused timing-sensitive world-space spawn interpolation). The test remains a must-pass screenshot test for issue 1773. Reference images must be regenerated on the CI reference machine. Co-authored-by: riccardobl <4943530+riccardobl@users.noreply.github.com>
Reverting the earlier removal of the moving emitter. The emission loop is purely tpf-driven and IsoTimer supplies a constant tpf, so the moving emitter is already deterministic across identical runs. The genuine flakiness source is the shared FastMath.rand state leaking between the two parameterized invocations. Resetting the seed per invocation makes the screenshot reproducible while keeping the existing reference images valid (the scene is unchanged). Also harden CI: - main.yml: restart Xvfb + stop Gradle daemon between screenshot retries to survive the X_PutImage BadLength Xlib crash - main.yml: retry publishToSonatype with backoff to absorb Maven Central 429s Co-authored-by: riccardobl <4943530+riccardobl@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
riccardobl
September 8, 2026 09:46
View session
riccardobl
marked this pull request as ready for review
September 8, 2026 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Build jMonkeyEngineworkflow was failing intermittently from three independent transient causes: a flaky screenshot test, an Xvfb crash that poisoned retries, and unretried Maven Central rate-limiting.Changes
TestIssue1773(ScenarioIssue1773.java): The emitter shape samples random torus vertices from the sharedFastMath.rand, whose state leaked between the two parameterized invocations. The framework already fixestpfviaIsoTimer(60), so reseeding per invocation makes the render reproducible. The scene is unchanged, so existing reference images remain valid.Screenshot retry hardening (
main.yml): between attempts, stop Gradle daemons (./gradlew --stop) and restart Xvfb. Previously anX_PutImage/BadLengthXlib crash killed the test JVM and the corrupted X server state carried into the next retry, wasting attempts.Maven 429 backoff (
main.yml):publishToSonatypenow retries 3× with 30s/60s backoff. A single429 Too Many Requestsduring dependency resolution previously failed theDeploy Java Snapshotjob.Note
Screenshot tests could not be executed in the authoring sandbox (the root buildscript requires the Android Gradle plugin from a blocked host), so confirmation that
TestIssue1773is stable should come from a CI run. The seed fix also covers the Android variant, which sharesScenarioIssue1773.