Skip to content

Float type mismatch - #3030

Merged
yaRnMcDonuts merged 1 commit into
jMonkeyEngine:masterfrom
fba-rio:master
Oct 28, 2026
Merged

yaRnMcDonuts merged 1 commit into
jMonkeyEngine:masterfrom
fba-rio:master

Conversation

@fba-rio

@fba-rio fba-rio commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Fix float type mismatch in dot() comparison.

Fix float type mismatch in dot() comparison.

@jaime-jmebot jaime-jmebot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — small and correct.

  • dot() returns a float, so comparing against 0.0 instead of 0 removes the int→float implicit conversion, which stricter compilers (notably GLSL ES on mobile/WebGL) reject.
  • The change now matches the non-multisample PostShadowFilter.frag, so both shadow-filter variants behave identically.
  • The extra spacing/brace-indentation tidy-up is harmless and keeps the block consistent with the rest of the file.

Thanks for the fix!

@yaRnMcDonuts
yaRnMcDonuts merged commit c9d16ef into jMonkeyEngine:master Oct 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants