Repository navigation
Float type mismatch - #3030
Merged
Merged
Float type mismatch#3030
Conversation
Fix float type mismatch in dot() comparison.
jaime-jmebot
approved these changes
Oct 27, 2026
jaime-jmebot
left a comment
Contributor
There was a problem hiding this comment.
Looks good — small and correct.
dot()returns afloat, so comparing against0.0instead of0removes the int→float implicit conversion, which stricter compilers (notably GLSL ES on mobile/WebGL) reject.- The change now matches the non-multisample
PostShadowFilter.frag, so both shadow-filter variants behave identically. - The extra spacing/brace-indentation tidy-up is harmless and keeps the block consistent with the rest of the file.
Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix float type mismatch in dot() comparison.