Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cache-manager/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
"@keyv/redis": "^5.1.6",
"cache-manager-redis-yet": "^5.1.5",
"cacheable": "workspace:^",
"keyv6": "npm:keyv@^6.1.0",
"tsdown": "^0.23.0",
"typescript": "^7.0.2"
}
Expand Down
6 changes: 3 additions & 3 deletions packages/cache-manager/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ export const createCache = (options?: CreateCacheOptions): Cache => {
if (nonBlocking) {
try {
result = await Promise.race(
stores.map(async (store) => store.get(key, { raw: true })),
stores.map(async (store) => store.getRaw(key)),
);
if (result === undefined) {
return undefined;
Expand All @@ -196,7 +196,7 @@ export const createCache = (options?: CreateCacheOptions): Cache => {
} else {
for (const store of stores) {
try {
const cacheValue = await store.get(key, { raw: true });
const cacheValue = await store.getRaw(key);
if (cacheValue !== undefined) {
result = cacheValue;
eventEmitter.emit("ttl", { key, value: result });
Expand Down Expand Up @@ -349,7 +349,7 @@ export const createCache = (options?: CreateCacheOptions): Cache => {

for (; i < stores.length; i++) {
try {
const data = await stores[i].get<T>(key, { raw: true });
const data = await stores[i].getRaw<T>(key);
if (data !== undefined) {
value = data.value;
rawData = data;
Expand Down
30 changes: 30 additions & 0 deletions packages/cache-manager/test/keyv6.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import { faker } from "@faker-js/faker";
import type { Keyv } from "keyv";
import { Keyv as Keyv6 } from "keyv6";
import { describe, expect, it, vi } from "vitest";
import { createCache } from "../src/index.js";

describe("Keyv 6 store", () => {
const ttl = 1000;
// The `stores` option has the Keyv 5 type, so a Keyv 6 instance needs a cast.
const createKeyv6Cache = () =>
createCache({ stores: [new Keyv6() as unknown as Keyv] });

it("wrap returns the cached value", async () => {
const cache = createKeyv6Cache();
const key = faker.string.alpha(20);
const getValue = vi.fn(() => ({ id: 1 }));

await cache.wrap(key, getValue, ttl);
await expect(cache.wrap(key, getValue, ttl)).resolves.toEqual({ id: 1 });
expect(getValue).toBeCalledTimes(1);
});

it("ttl returns the expiration", async () => {
const cache = createKeyv6Cache();
const key = faker.string.alpha(20);

await cache.set(key, faker.string.sample(), ttl);
await expect(cache.ttl(key)).resolves.toBeGreaterThan(Date.now());
});
});
8 changes: 4 additions & 4 deletions packages/cache-manager/test/multiple-stores.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ describe("multiple stores", () => {
await expect(keyv2.get(data.key)).resolves.toEqual(data.value);

// Store 1 get error
keyv1.get = () => {
keyv1.getRaw = () => {
throw new Error("store 1 get error");
};

Expand All @@ -92,20 +92,20 @@ describe("multiple stores", () => {
await expect(keyv2.get(data.key)).resolves.toEqual(data.value);

// Store 1 get error
const getOk = keyv1.get;
const getOk = keyv1.getRaw;
const getError = () => {
throw new Error("store 1 get error");
};

keyv1.get = getError;
keyv1.getRaw = getError;

await sleep(ttl - refreshThreshold + 100);

await expect(
cache.wrap(data.key, () => "new", ttl, refreshThreshold),
).resolves.toEqual(data.value);

keyv1.get = getOk;
keyv1.getRaw = getOk;
// Store 1 has been updated the latest value
await expect(keyv1.get(data.key)).resolves.toEqual("new");
await expect(cache.wrap(data.key, () => "latest", ttl)).resolves.toEqual(
Expand Down
4 changes: 2 additions & 2 deletions packages/cache-manager/test/ttl.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@ describe("get", () => {

it("error", async () => {
await cache.set(data.key, data.value);
keyv.get = () => {
keyv.getRaw = () => {
throw new Error("get error");
};

await expect(cache.ttl(data.key)).resolves.toBeUndefined();
});
it("error on non-blocking enabled", async () => {
const secondKeyv = new Keyv();
keyv.get = () => {
keyv.getRaw = () => {
throw new Error("get error");
};

Expand Down
2 changes: 1 addition & 1 deletion packages/cache-manager/test/wrap.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ describe("wrap", () => {

it("store get failed", async () => {
const getValue = vi.fn(() => data.value);
keyv.get = () => {
keyv.getRaw = () => {
throw new Error("get failed");
};

Expand Down
11 changes: 11 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.