Skip to content

fix: never claim annotations in BuilderProcessor #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreasIgel merged 1 commit into from
Oct 5, 2026
Merged

fix: never claim annotations in BuilderProcessor #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion processor/src/main/java/org/javahelpers/simple/builders/processor/BuilderProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,15 @@ public synchronized void init(ProcessingEnvironment processingEnv) {
}
}

/**
* Always returns {@code false}, so this method intentionally never claims annotations (hence the
* {@code java:S3516} suppression). Claiming is all-or-nothing over the supported set and {@link
* SupportedAnnotationTypes} must stay {@code "*"} to discover user-defined template annotations;
* claiming would therefore hide every annotation in the round — including foreign ones like
* MapStruct's {@code @Mapper} — from later processors.
*/
@Override
@SuppressWarnings("java:S3516")
public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment roundEnv) {
if (!supportedJdk) {
// Fail fast: we already emitted an error in init(); do not attempt any processing.
Expand Down Expand Up @@ -187,7 +195,7 @@ public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment

// Reset indentation level at the end of each processing round to prevent cascading errors
context.resetIndentation();
return true;
return false;
}

/** Generates all Jackson modules after the last processing round and reports the metrics. */
Expand Down
Loading