Repository navigation
fix: disable generateUpdateHelpers in the ElementaryBuilder template - #334
Merged
AndreasIgel merged 1 commit intoOct 5, 2026
Conversation
@ElementaryBuilder predates the update-helpers option and documented a setter-only builder, but never disabled generateUpdateHelpers — so @ElementaryBuilder-annotated types got xyzUpdate(UnaryOperator<T>) methods anyway (visible in the committed BookDtoBuilder). Align it with @SimpleMinimalBuilder. Fixes java-helpers#333
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #333 — follow-up to #31 (the update-helpers feature, implemented in #223, postdates this template).
@ElementaryBuilder— the example's minimal template, documented onBookDtoas generating a setter-only builder — predates thegenerateUpdateHelpersoption and never disabled it.@ElementaryBuilder-annotated types therefore still gotxyzUpdate(UnaryOperator<T>)methods (visible in the committedBookDtoBuilder:authorUpdate,pagesUpdate, …).Adds
generateUpdateHelpers = OptionState.DISABLEDto the template (matching the built-in@SimpleMinimalBuilder) and regenerates the committed example builders —BookDtoBuilderis now setter-only as documented.Verification
mvn -pl example clean compileregeneratesBookDtoBuilderwithout the update methods and theUnaryOperatorimport; no other generated builder is touched.Written by Devin