feat: add a generic external command handoff - #41
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The strict MIT Core boundary intentionally removed product runtime, account, entitlement and host implementation code. That also removed the old command-dispatch path used by separately distributed functionality.
This restores only a product-neutral invocation seam. Core remains unaware of manifests, accounts, services, plans, capabilities or any separately distributed implementation.
What
agent-memorybin through a small launcher~/.agent-memory/bin/agent-memory-extensioncompanion (.exeon Windows)check:public-boundarywith an explicitsrc/*.tsallowlist in addition to the existing lexical scanBoundary properties
The public launcher contains no network access, remote origins, bundle loading, account state, authorization policy, licensing logic, host API, automatic capture implementation, or knowledge of separately distributed command names. Adding another public source module now requires an explicit boundary-check update.
Validation
CI should run the existing build/lint/unit/CLI/eval gates plus the new external-command test. The compiled launcher path should be exercised before merge because
build:clinow compilessrc/launcher.tsrather thansrc/cli.ts.