chore: bump process-compose from v1.110.0 to v1.116.0 (#2915)#2916
Open
jefft wants to merge 1 commit into
Open
chore: bump process-compose from v1.110.0 to v1.116.0 (#2915)#2916jefft wants to merge 1 commit into
jefft wants to merge 1 commit into
Conversation
This bump fixes a process-compose bug where services with process_healthy dependencies would hang forever (stuck in Pending state) when the target process had no readiness_probe or liveness_probe configured. v1.116.0 (commit 85686e5) adds a nil-check in waitIfNeeded() that returns a clear error instead of blocking on a channel that is never closed for processes without probes. Fixes jetify-com#2915
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This bump fixes a process-compose bug where services with
process_healthydependencies would hang forever (stuck in Pending state) when the target process had no readiness_probe or liveness_probe configured.process-compose v1.116.0 (commit 85686e5) adds a nil-check in waitIfNeeded() that returns a clear error instead of blocking on a channel that is never closed for processes without probes.
Changes made:
go.mod: changed github.com/f1bonacc1/process-compose v1.64.1 to v1.116.0internal/devbox/util.go: changed const processComposeVersion = "1.110.0" to "1.116.0"go mod tidy: updated go.sum and indirect dependenciesFixes #2915
How was it tested?
First build a devbox with a working #2909 isolated #2906 mariadb plugin (unless those have been merged), plus this PR:
Then using modified repro script from #2915:
With the fixed process-compose the myapp service is in Skipped, and the log contains a clear error message:
Community Contribution License
All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.