Enforce leading-slash requirement on path parameters in ArtifactoryImpl - #456
Merged
Merged
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
fluxxBot
force-pushed
the
RTECO-2308
branch
from
September 16, 2026 13:43
54904e4 to
1bbb1e0
Compare
agrasth
approved these changes
Sep 17, 2026
reshmifrog
approved these changes
Sep 17, 2026
fluxxBot
added a commit
that referenced
this pull request
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArtifactoryImplbehind a singlebuildUri(String path)helperbuildUrivalidates thatpathstarts with/before concatenating with the configured base URL, throwingIllegalArgumentExceptionfor invalid inputURI.create(url + path)call sites (get, head, post, put, patch, delete, handleArtifactoryRequest) with the shared helperatPrefixedPathMustBeRejectedcovering malformed paths and confirming valid paths are unaffectedAlso in this PR
CargoPackageTypeRepositoryTests: dropcargoInternalIndexandgitRegistryUrlfrom test settings — Artifactory 7.46.3 removed legacy Git index support for all Cargo repo types; sparse HTTP index is now the only accepted modeshell: bashto "Wait for Artifactory" and "Cleanup test repositories" steps so they run correctly on Windows runners; skip Artifactory-dependent steps on macOS where the local install does not start reliably