Conversation
Use require.True/require.NoError instead of assert.True/assert.NoError when checking GetBuildInfo results. The soft assert variants allow execution to continue when found=false, causing a nil pointer dereference at publishedBuildInfo.BuildInfo.Modules on the next line. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Contributor
|
I have read the CLA Document and I hereby sign the CLA pm-compat-fixer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestNpmBuildPublishWithCIVcsPropspanicked atnpm_test.go:1676with a nil pointer dereference. The build info was successfully deployed (per the CI log), buttests.GetBuildInforeturnedfound=false(likely due to Artifactory index propagation lag under CI load, even with the existing retry logic). Because lines 1667–1668 used softassert.NoError/assert.Trueinstead ofrequire, test execution continued past thefound=falsecheck, and the loop at line 1676 dereferenced the nilpublishedBuildInfo.BuildInfo.Modules.Fix
Changed
assert.NoError→require.NoErrorandassert.True→require.Truefor the two pre-condition checks onGetBuildInfo's return values (lines 1667–1668 ofnpm_test.go). This is a test-only fix: whenfound=falseorerr != nil, the test now fails immediately and cleanly instead of panicking. No product behavior changed.Compatibility impact
No exported symbols were added, removed, or changed. This is a two-line test-helper change confined to
npm_test.go. All supported versions are unaffected.Test plan
go build ./...— could not run: Go toolchain not installed in this environment.gofmt -l .— could not run: Go toolchain not installed in this environment.go vet ./...— could not run: Go toolchain not installed in this environment.assert→requireon both checks guarding the same nil pointer); no logic was altered.Opened automatically by PM Compat Fixer investigating yarn @yarnpkg/cli/3.6.4.