Conversation
…on (Classic + FlexPack) Adds two end-to-end tests verifying that a dependency declared only in a shared buildSrc convention plugin (never in the api module's own build.gradle) is correctly present in the published build-info, for both Gradle execution modes: - TestGradleBuildSharedBuildLogicClassic: plugin auto-injected via the init script (default jf gradle mode). - TestGradleBuildSharedBuildLogicFlexPack: native mode (JFROG_RUN_NATIVE=true). New fixture: testdata/gradle/buildsrcdependency (root + buildSrc + api, convention plugin declares org.slf4j:slf4j-api, api uses it via a real class without declaring it directly). The FlexPack test explicitly removes any leftover .jfrog config before running, since ShouldRunNative refuses native mode when a .jfrog/projects/gradle.yaml is found via upward directory search, and this fixture name is shared with the Classic test.
Adds a "lib" submodule to the buildsrcdependency fixture that deliberately does NOT apply the shared java-common-conventions plugin. Extends the shared-build-logic test assertions to also verify lib's published build-info does NOT contain org.slf4j:slf4j-api, proving the convention plugin's dependency only reaches subprojects that actually apply it, not the whole build.
udaykb2
marked this pull request as draft
September 25, 2026 09:58
Adds TestGradleBuildSharedBuildLogicBuildLogicClassic and TestGradleBuildSharedBuildLogicBuildLogicFlexPack, mirroring the existing buildSrc-based tests but with the shared convention plugin living in an included build-logic build instead. Covers the same positive (api gets org.slf4j:slf4j-api) and negative (lib, which does not apply the convention plugin, does not) assertions, for both Classic and FlexPack modes. New fixture: testdata/gradle/buildlogicdependency (root + build-logic + api + lib), mirroring buildsrcdependency's structure.
…tps://github.com/jfrog/jfrog-cli into RTECO-132-gradle-shared-build-logic-support-test
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....