Skip to content

feat: add gherkin and test parsers - #144

Merged
uid11 merged 1 commit into
mainfrom
feat/add-test-and-gherkin-parsers
Aug 20, 2026
Merged

feat: add gherkin and test parsers#144
uid11 merged 1 commit into
mainfrom
feat/add-test-and-gherkin-parsers

Conversation

@uid11

@uid11 uid11 commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other (please describe):

feat: add gherkin and test parsers.
fix: prepare e2ed/utils for importing in CI/precommit scripts.
feat: add readFilesByGlobs fs-utility.
test: add tests on parseTest function.

@uid11
uid11 force-pushed the feat/add-test-and-gherkin-parsers branch 5 times, most recently from 5ef5ed3 to 4dc65c9 Compare August 15, 2026 03:42
@uid11
uid11 requested a review from ingvar-snow August 15, 2026 03:44
@uid11
uid11 force-pushed the feat/add-test-and-gherkin-parsers branch 5 times, most recently from 658e1d4 to 064c097 Compare August 16, 2026 06:56
fix: prepare e2ed/utils for importing in CI/precommit scripts
feat: add `readFilesByGlobs` fs-utility
test: add tests on `parseTest` function
@uid11
uid11 force-pushed the feat/add-test-and-gherkin-parsers branch from 064c097 to 9762159 Compare August 17, 2026 12:10

@ingvar-snow ingvar-snow left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion:
It would be good if we write unit tests for the functions in parseTests.
To better understand how they should work, what they receive as input parameters, and what they should return.

Comment thread src/utils/packCompiler/compilePack.ts
Comment thread src/utils/step/runStepBody.ts
Comment thread src/utils/viewport/isSelectorInViewport.ts
@ingvar-snow
ingvar-snow self-requested a review August 18, 2026 14:21
@uid11

uid11 commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator Author

suggestion: It would be good if we write unit tests for the functions in parseTests. To better understand how they should work, what they receive as input parameters, and what they should return.

Yes. In fact, such unit tests are located in this file.

@uid11
uid11 merged commit 4bab1bf into main Aug 20, 2026
6 checks passed
@uid11
uid11 deleted the feat/add-test-and-gherkin-parsers branch August 20, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants