Skip to content

Phan discovered a few issues #17

Description

@Hackwar

Please have a look at the result of phan for 3.x-dev, because there is a mismatch in what the methods are doing. The dump() method has an interface which declares the return type as stdclass, while in DataSet::dump() it is declared as array. At the same time the method DataObject::jsonSerialize() is defined to return a string, but currently returns the object from dump() instead. It looks like a json_encode() is missing here and that DataSet::dump() is defined wrong.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions