Repository navigation
docs: note where the br region in resolve-saic-rest-uri.sh comes from - #613
Merged
Merged
Conversation
The comment named the gateway README's "API Endpoints" table as the source of truth, but that table does not list Brazil until SAIC-iSmart-API/saic-python-mqtt-gateway#527 is merged. Say so, and name the other projects that use the gateway-mg-br endpoint (see joszz#594), so a later reader does not remove br as unknown. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
joszz
force-pushed
the
docs/saic-region-br-note
branch
from
November 13, 2026 04:33
afb2acb to
c2a740d
Compare
joszz
enabled auto-merge
November 13, 2026 04:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review of #597. The comment at the top of
docker/resolve-saic-rest-uri.shnamed the gateway README's "API Endpoints" table as the source of truth, but that table does not list Brazil until SAIC-iSmart-API/saic-python-mqtt-gateway#527 is merged. The comment now says so, and names the other projects that use thegateway-mg-brendpoint (listed in #594), so a later reader does not removebras unknown.Comment-only change. I ran the script with
shforeu,au,tr,br, an unknown region, no region, and an explicitSAIC_REST_URI; the output is unchanged from before.🤖 Generated with Claude Code