Skip to content

Fix MOI.AbstractFunctionModification for SetDotScalingBridge #3123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odow merged 1 commit into from
Oct 29, 2026
+47 −0
Merged

Fix MOI.AbstractFunctionModification for SetDotScalingBridge #3123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions src/Bridges/Constraint/bridges/SetDotScalingBridge.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,35 @@ function MOI.Bridges.inverse_adjoint_map_function(
return _scale(T, S, func)
end

function MOI.modify(
model::MOI.ModelLike,
bridge::SetDotScalingBridge{T,S},
change::MOI.MultirowChange{T},
) where {T,S}
set = MOI.get(model, MOI.ConstraintSet(), bridge.constraint).set
scale = MOI.Utilities.SetDotScalingVector{T}(set)
new_coefficients = Tuple{Int64,T}[
(row, scale[row] * coef) for (row, coef) in change.new_coefficients
]
MOI.modify(
model,
bridge.constraint,
MOI.MultirowChange(change.variable, new_coefficients),
)
return
end

function MOI.modify(
model::MOI.ModelLike,
bridge::SetDotScalingBridge,
change::MOI.VectorConstantChange,
)
new_constant = MOI.Bridges.map_function(bridge, change.new_constant)
new_change = MOI.VectorConstantChange(new_constant)
MOI.modify(model, bridge.constraint, new_change)
return
end

"""
SetDotInverseScalingBridge{T,S,F,G} <: Bridges.Constraint.AbstractBridge

Expand Down
18 changes: 18 additions & 0 deletions test/Bridges/Constraint/test_SetDotScalingBridge.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,24 @@ function test_set_dot_inverse_scaling_constraint_dual_start()
return
end

function test_modify()
inner = MOI.Utilities.Model{Float64}()
model = MOI.Bridges.Constraint.SetDotScaling{Float64}(inner)
x = MOI.add_variables(model, 3)
f = MOI.Utilities.vectorize(1.0 .* x)
c = MOI.add_constraint(model, f, MOI.PositiveSemidefiniteConeTriangle(2))
@test ≈(MOI.get(model, MOI.ConstraintFunction(), c), f)
MOI.modify(model, c, MOI.VectorConstantChange([3.0, 4.0, 5.0]))
f.constants .= [3.0, 4.0, 5.0]
@test ≈(MOI.get(model, MOI.ConstraintFunction(), c), f)
MOI.modify(model, c, MOI.MultirowChange(x[1], [(1, 2.1)]))
MOI.modify(model, c, MOI.MultirowChange(x[2], [(2, 2.2)]))
MOI.modify(model, c, MOI.MultirowChange(x[3], [(3, 2.3)]))
f = MOI.Utilities.vectorize([2.1, 2.2, 2.3] .* x .+ [3.0, 4.0, 5.0])
@test ≈(MOI.get(model, MOI.ConstraintFunction(), c), f)
return
end

end # module

TestConstraintSetDotScaling.runtests()
Loading