Repository navigation
Conversation
`buffer_for(LinearAlgebra.dot, ...)` and `buffered_operate_to!(buffer, output, LinearAlgebra.dot, x, y)` were only implemented for `BigFloat` vectors. For other element types, the buffer of the scalar `add_dot` is now returned and reused for every entry so that computing several dot products with the same buffer and output does not allocate. `operate_to!(output, LinearAlgebra.dot, x, y)` is also implemented.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
=======================================
Coverage ? 92.09%
=======================================
Files ? 23
Lines ? 2390
Branches ? 0
=======================================
Hits ? 2201
Misses ? 189
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 28, 2026
Open
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buffer_for(LinearAlgebra.dot, ...)andbuffered_operate_to!(buffer, output, LinearAlgebra.dot, x, y)were only implemented forBigFloatvectors in #193. For other element types, the buffer of the scalaradd_dotis now returned and reused for every entry so that computing several dot products with the same buffer and output does not allocate.operate_to!(output, LinearAlgebra.dot, x, y)is also implemented.Minimum time from BenchmarkTools. The buffer and the output are created once and reused across calls:
LinearAlgebra.dotbuffered_operate_to!!BigInt, n = 6BigInt, n = 50Rational{BigInt}, n = 6Rational{BigInt}, n = 50