Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTPS requests were proxied to Core without their original scheme, so generated PAM Agent/SDK materials and copied application connection information could contain HTTP URLs.
Forward the connection scheme at the Web entry point. Under the existing trusted load-balancer mode (
USE_LB=0), preserve an upstreamhttporhttpsvalue and fall back to the connection scheme for missing or invalid values. Keep the default mode from trusting client-supplied protocol headers.Validation:
bash -n init.shandgit diff --checkpassed.python3 -m unittest discover -s tests -v: 5 tests passed, including 32 combinations through real Nginx HTTP/HTTPS entry points and the internal Core proxy hop.Only docker-web changes are included. Live deployment and actual client connections were not performed.