E2E test roleassignment-dependency fix racy - #861
Merged
Merged
Conversation
…ency test — CEL expressions for the dependency being deleted (avoids racing with the Project controller's status updates), and standard status assertions for the RoleAssignment which isn't being deleted and has stable conditions. Signed-off-by: Daniel Lawton <dlawton@redhat.com>
mandre
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix replaces the racy Project status condition assertions with CEL expressions that check what actually matters: the Project has a
deletionTimestamp(deletion was requested) and theopenstack.k-orc.cloud/roleassignment finalizeris still blocking it. The RoleAssignment assertions stay as-is since they're stable , the RoleAssignment itself isn't being deleted, so its conditions won't race. CEL expressions from security group used as inspiration https://github.com/k-orc/openstack-resource-controller/blob/main/internal/controllers/securitygroup/tests/securitygroup-dependency/02-assert.yamlIn response to OpenStack-Gazpacho roleassignment-dependency racy failure in #853