Implement Limit controller - #868
Open
chenwng wants to merge 13 commits into
Open
Conversation
go run ./cmd/scaffold-controller -interactive=false \
-kind=Limit \
-gophercloud-client=NewIdentityV3 \
-gophercloud-module=github.com/gophercloud/gophercloud/v2/openstack/identity/v3/limits \
-gophercloud-type=Limit \
-openstack-json-object=limit \
-available-polling-period=0 \
-deleting-polling-period=0 \
-required-create-dependency=Service \
-optional-create-dependency=Project \
-optional-create-dependency=Domain \
-import-dependency=Service \
-import-dependency=Project \
-import-dependency=Domain
chenwng
force-pushed
the
limit-controller
branch
from
July 28, 2026 14:22
c416088 to
e556212
Compare
Update generated resources to reflect the addition of description in Limit spec Update the OLM bundle
chenwng
force-pushed
the
limit-controller
branch
from
July 29, 2026 11:06
e556212 to
0b8d70e
Compare
dlaw4608
reviewed
Jul 29, 2026
dlaw4608
reviewed
Jul 29, 2026
dlaw4608
reviewed
Jul 29, 2026
dlaw4608
left a comment
dlaw4608
left a comment
Contributor
There was a problem hiding this comment.
Hey Winston, great job on the PR!! , I left a few comments after a quick first look, I am looking into it more but just to show you what I found so far WDYT?
Fix parameters in dependencies in Limit actuator Fix default name in test utils
Debug CI e2e failures
Contributor
Author
|
Thanks @dlaw4608 for the review. I will fix them. At the same time, I am also trying to figure out the CI failures. |
chenwng
force-pushed
the
limit-controller
branch
from
July 29, 2026 13:53
0b8d70e to
b41c2e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the controller for
Limitin Keystone.Regionis not included in the spec as it is not available in ORC yet.As
Limitdepends onRegisteredLimitwhich hasn't been merged yet, a setup deployment is used in e2e test cases to create requiredRegisteredLimits and remove them when tearing down cases. The deployment is also used to disable createdDomains to facilitate the deletion of them.Close #851