Repository navigation
feat: add configurable timeouts for emitters - #17
Draft
kahirokunn wants to merge 2 commits into
Draft
kahirokunn wants to merge 2 commits into
kahirokunn wants to merge 2 commits into
Conversation
Give each emitter invocation a configurable deadline and combine it with the caller's abort signal. Preserve transport result and option types, including per-send HTTP response handlers, and dispose timers and signal subscriptions when the invocation settles. The wrapped emitter must honor its signal. This feature is independent of retry behavior and does not change the built-in transport's default send. Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Keep timeout and retry independently reviewable, then check their combined behavior when both wrappers are available. Restore the existing per-attempt timeout coverage and document both wrapper orders. Verify that a whole-delivery deadline interrupts retry backoff before a second attempt, preserving the timeout reason rather than resending. Signed-off-by: kahirokunn <okinakahiro@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kahirokunn
added this pull request to stack #18
October 13, 2026 04:41
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: cloudevents#564
Proposed Changes
Add configurable emitter timeouts with
withTimeout().Description
withTimeout()combines a per-call deadline with the caller's abort signal. InsidewithRetry(), each attempt gets a fresh timeout; outside it, one timeout covers all attempts and backoff. The default retry policy does not retry timed-out HTTP sends.