fix: declare React 19 support in the peer range - #21
Open
slayerjain wants to merge 1 commit into
Open
Conversation
DiffViewer is a class component, and React 19 only removed defaultProps for FUNCTION components, so the static defaultProps here are unaffected. Nothing else in src/ uses an API React 19 dropped. The range simply never got updated: keploy/enterprise-ui runs this on React 19.2 today with a green build and full unit suite, and only gets away with it because every install there passes --legacy-peer-deps. That flag then hides genuine peer conflicts across the whole tree, so a range that is merely stale is not harmless — it is one of the reasons the flag cannot be dropped. This declares what already works. It does not address the larger gap: this fork sits on react-diff-viewer-continued 3.2.2 while upstream is at 4.4.0, and still pulls emotion 10. Signed-off-by: slayerjain <shubhamkjain@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiffViewer is a class component, and React 19 only removed defaultProps for
FUNCTION components, so the static defaultProps here are unaffected. Nothing
else in src/ uses an API React 19 dropped.
The range simply never got updated: keploy/enterprise-ui runs this on React
19.2 today with a green build and full unit suite, and only gets away with it
because every install there passes --legacy-peer-deps. That flag then hides
genuine peer conflicts across the whole tree, so a range that is merely stale
is not harmless — it is one of the reasons the flag cannot be dropped.
This declares what already works. It does not address the larger gap: this fork
sits on react-diff-viewer-continued 3.2.2 while upstream is at 4.4.0, and still
pulls emotion 10.
Signed-off-by: slayerjain shubhamkjain@outlook.com