Repository navigation
Fix validate boots job names - #320
Draft
nuclearcat wants to merge 6 commits into
Draft
nuclearcat wants to merge 6 commits into
nuclearcat wants to merge 6 commits into
Conversation
Retry filtering only happened during missing-id checks. Counts and boot status checks still used raw Maestro nodes. Share the filtered Maestro set and keep missing checks dashboard-only. Add regression tests for count, status, and missing-id behavior. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
Boot validation dropped every failed Maestro boot with retry_counter < 3, assuming job-retry would replace it. job-retry only retries failed baseline jobs, and the KCIDB bridge sends failed non-baseline boot jobs to KCIDB on the first attempt. Validating such jobs would report them as extra in the dashboard. Drop failed boots pending retry only for baseline jobs, as the pipeline does. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
CIP boot jobs are named job-*-cip instead of baseline-*, but the pipeline sends them to KCIDB as boots. The Maestro boot query only matched ^baseline, so CIP checkouts reported 0 Maestro boots and every dashboard boot as extra. Match job-*-cip too. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
Maestro nodes carry nothing that marks a job as a boot; the pipeline's KCIDB bridge decides that from each job's kcidb_test_suite. Matching boot jobs by name breaks silently whenever a boot job does not follow the expected naming. Add --pipeline-config to "maestro validate boots". It reads the kernelci-pipeline YAML config and queries Maestro for exactly the jobs whose kcidb_test_suite starts with "boot". Without the option, keep matching by name. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patches will fix pending issues that block from deploying notifications in discord about missing jobs (disrepancy between maestro/dashboard, for example some tests/builds are missing, etc).
Example: https://github.com/kernelci/kernelci-pipeline/actions/runs/38553489511