Repository navigation
Conversation
Use qemu_docker_image from job or platform parameters while retaining kernelci/qemu as the default. Document configuration and cover generated LAVA jobs with regression tests. Fixes kernelci#2591 Signed-off-by: Jiakai Xu <jiakaiPeanut@gmail.com>
Member
|
Thanks, this looks straightforward and addresses the use case described in #2591. Is that requirement still active in a lab you work with? Have you tried this on a real LAVA worker with an alternative registry? A successful job link, ideally using a mirror of the existing image, would help validate the end-to-end behavior. |
Author
|
Thanks for your review! @nuclearcat
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use qemu_docker_image from job or platform parameters while retaining kernelci/qemu as the default. Document configuration and cover generated LAVA jobs with regression tests.
Fixes #2591