Lock down snmp as read-only and sanitize input - #1656
Merged
Merged
Conversation
snmpd.conf is line oriented and confd writes these values verbatim, so a newline in a community or security name appended directives of the operator's choosing, granting write access to a read-only agent. Restrict the leaves that reach the file, derived from the original types so the RFC 7407 lengths still apply. /system/contact and /system/location are ietf-system free text, dropped at render instead. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The agent is read-only by design. Remove SET from the build so a mistake in the generated VACM configuration cannot make it writable. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
mattiaswal
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With simple config file injection it was possible to enable write mode in SNMP. Lock it down with
--enable-read-only, tighten the text field types in YANG, and sanitize all data before writing tosnmpd.confChecklist
Tick relevant boxes, this PR is-a or has-a: