Edit fixes - #1662
Merged
Merged
Edit fixes#1662
Conversation
With /bin/sh now BusyBox ash, askline fails before prompting:
askline: read: line 13: illegal option -e
This breaks the CLI edit command on string settings, datetime -e, and
editing the boot order. Prefilling the line with the current value
needs read -e -i, which only bash has.
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The result of read was never checked, so Ctrl-D at the first prompt did not abort. askpass asked for the retype and only then failed with "Empty Passphrase, try again." The mismatch and empty errors went to stdout, which is where the encoded secret goes when no OUTPUT file is given. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
mattiaswal
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix broken
/usr/bin/asklinefunctionality, used by, e.g.,edit system hostname. Broke when thebinshwas merged because BusyBox ash, which is now/bin/sh, does not supportread -e.Also, add some hardening to
/usr/bin/askpass, lessons from askline.Regression in the same release cycle, so no ChangeLog changes needed.
Setting
ci:skipon this since none of the changes have any tests or are compiled.Checklist
Tick relevant boxes, this PR is-a or has-a: