check camelcase in linter and add special handling - #5011
Merged
Merged
Conversation
Contributor
Author
|
Also if people like this change, it should go in before #5004 |
|
The commits b1e1e72...04a19b2 introduce visual changes on linux. |
gabriel
approved these changes
Dec 5, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checks camel cases, and makes shorthands such as
TLFandIDlegit.Although in Go it'd still beRelevant PR inTlfMessageunless we change the Go emitter. (I guess the Go compiler thing isn't really urgent since we can change it anytime without changing content on the wire.)node-avdl-compiler: keybase/node-avdl-compiler#10r? @gabriel @maxtaco @patrickxb Thanks!