Skip to content

fix(settings): disable mouse events by default #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esphynox merged 2 commits into from
Sep 3, 2026
Merged

fix(settings): disable mouse events by default #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1de76be
fix(settings): disable mouse events by default
esphynox Sep 3, 2026
6efc1b7
test(settings): preserve enabled mouse preview coverage
esphynox Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Apps/Keyty/Sources/Keyty/Features/Visualizers/Keyboard/KeyboardVisualizerSettings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ final class KeyboardVisualizerSettings: KeyboardVisualizerSettingsProtocol, HasS
var showMediaKeyButtons: Bool

/// Whether mouse clicks and wheel events should be rendered in the keyboard overlay.
@Stored(.bool(KeyboardVisualizerSettingsKeys.showMouseEvents, default: true))
@Stored(.bool(KeyboardVisualizerSettingsKeys.showMouseEvents, default: false))
var showMouseEvents: Bool

var themeTokens: KeycapThemeTokens {
Expand Down
5 changes: 5 additions & 0 deletions Apps/Keyty/Tests/KeytyTests/Features/Settings/Keyboard/KeyboardSettingsPreviewTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ final class KeyboardSettingsPreviewTests: XCTestCase {
}

func testPreviewGroupsIncludeAllEnabledCategories() {
settings.showMouseEvents = true

let groups = KeyboardSettingsPane.PreviewGroup.previewGroups(settings: settings)

XCTAssertEqual(groups.map(\.category), [
Expand All @@ -41,6 +43,7 @@ final class KeyboardSettingsPreviewTests: XCTestCase {

func testPreviewGroupsOmitPlainKeyCategoryWhenShowingModifiedKeystrokesOnly() {
settings.onlyShowModifiedKeystrokes = true
settings.showMouseEvents = true

let groups = KeyboardSettingsPane.PreviewGroup.previewGroups(settings: settings)

Expand All @@ -54,6 +57,7 @@ final class KeyboardSettingsPreviewTests: XCTestCase {

func testPreviewGroupsOmitSpecialKeyCategoryWhenDisabled() {
settings.showSpecialKeys = false
settings.showMouseEvents = true

let groups = KeyboardSettingsPane.PreviewGroup.previewGroups(settings: settings)

Expand All @@ -67,6 +71,7 @@ final class KeyboardSettingsPreviewTests: XCTestCase {

func testPreviewGroupsOmitMediaCategoryWhenDisabled() {
settings.showMediaKeyButtons = false
settings.showMouseEvents = true

let groups = KeyboardSettingsPane.PreviewGroup.previewGroups(settings: settings)

Expand Down
2 changes: 1 addition & 1 deletion ...ts/KeytyTests/Features/Visualizers/Keyboard/Keycaps/KeyboardVisualizerSettingsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ final class KeyboardVisualizerSettingsTests: XCTestCase {
XCTAssertEqual(self.store.bool(forKey: KeyboardVisualizerSettingsKeys.collapseRepeatedGroups), false)
XCTAssertEqual(self.store.bool(forKey: KeyboardVisualizerSettingsKeys.showSpecialKeys), true)
XCTAssertEqual(self.store.bool(forKey: KeyboardVisualizerSettingsKeys.showMediaKeyButtons), true)
XCTAssertEqual(self.store.bool(forKey: KeyboardVisualizerSettingsKeys.showMouseEvents), true)
XCTAssertEqual(self.store.bool(forKey: KeyboardVisualizerSettingsKeys.showMouseEvents), false)
}

func testSharedKeyboardVisualizerSettingsFallbackAndClamping() {
Expand Down
Loading