fix(keyboard): collapse shortcuts while modifier is held - #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finalize each shortcut when its non-modifier key is released, so repeated shortcuts collapse and the history limit is enforced even while Command remains held.
Fixes #145.
Tests
tuist generatexcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS'xcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS' -only-testing:KeytyTests/KeyboardVisualizerTestsRun project commands from
Apps/Keyty.UI Changes
keyty-shortcut-group-collapse-before.mp4
keyty-shortcut-group-collapse-after.mp4
Documentation
Release Notes
Fixed shortcut history growing beyond its limit and repeated shortcuts not collapsing while a modifier key is held.