Repository navigation
Fix SonarCloud HIGH issues: S1192 duplicated literals, S7688 shell tests - #14
Conversation
Resolves 27 HIGH-severity code-smell issues that are safe, mechanical fixes. - shelldre:S7688 (start.sh): convert all `[ ... ]` conditionals to `[[ ... ]]` (script is bash; `[[` is the recommended, safer construct). - python:S1192 (11 files): hoist duplicated string literals into named module constants — HTML fragments in email_report_html.py, the git pathspec in cli_runs_diff.py, the "Git LFS" label, the "reports." TOML prefix, and the repeated Textual query selectors / labels across the GUI views and setup wizard. Also gitignore the local .sonar_cloud_token helper file. No behavior change. 732 tests OK, typecheck clean, ruff clean, bash -n clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
1 participant
Summary
Resolves 27 HIGH-severity SonarCloud issues — the safe, mechanical subset.
shelldre:S7688(6) — convert all[ … ]conditionals instart.shto[[ … ]](script is bash;[[is the recommended, safer construct).python:S1192(21) — hoist duplicated string literals into named module constants across 11 files: HTML fragments (email_report_html.py), the.github/workflows/git pathspec (cli_runs_diff.py), the"Git LFS"label, the"reports."TOML prefix, and the repeated Textual query selectors / button labels across the GUI views and setup wizard.Also gitignores the local
.sonar_cloud_tokenhelper file.Not included (intentionally)
python:S5754(5) — catching argparse'sSystemExitto return an int exit code is required by thecli:mainconsole-script contract; handled as accept-as-intentional in SonarCloud rather than code changes.python:S3776(25) — cognitive-complexity refactors; being done separately, function by function with tests.Verification
unittest discover)bash -n start.sh: cleanNo behavior change.
🤖 Generated with Claude Code