fix(core): satisfy clippy::manual_flatten in scan stat pass - #3
Merged
Merged
Conversation
The parallelized stat pass used `for res in children.iter_mut() { if let Ok(e) = res }`,
which clippy::manual_flatten denies under -D warnings. Iterate the Ok entries directly
via .flatten(); no behaviour change.
A new advisory (RUSTSEC-2026-0204: invalid pointer dereference in the fmt::Pointer impl for Atomic/Shared) was published against crossbeam-epoch 0.9.18, pulled transitively via jwalk and rayon — turning cargo-deny red on its own. Lockfile-only bump to the patched 0.9.20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.5.0 perf change (#2) parallelised the scan stat pass with
which
clippy::manual_flattendenies under-D warnings, turning main CI red on all three OS. Iterate theOkentries directly via.flatten()— no behaviour change.Verified locally:
cargo clippy --workspace --all-targets -- -D warningsandcargo fmt --all --checkboth clean.