test: bound on-disk byte assertions so CI passes on Unix (0.6.2) - #6
Merged
Merged
Conversation
The 0.6.1 on-disk-size change made scan/remove totals report allocated bytes, which round up to the block size on ext4/apfs. Four tests still asserted exact logical byte counts and failed on the Linux/macOS CI runners (Windows normal files report logical == on-disk, so it passed locally). Switch those to lower-bound / file-count assertions, which hold on every filesystem; logical exactness is still checked via logical_size. Release binaries are unchanged; this is a test-only fix plus a version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.6.1 on-disk-size change made scan/remove totals report allocated bytes, which round up to the block size on ext4/apfs. Four tests still asserted exact logical byte counts and failed on the Linux/macOS CI runners (Windows normal files report
logical == on-disk, so it passed locally and the release built fine).Fix: switch those four assertions to lower-bound / file-count checks that hold on every filesystem. Logical exactness is still verified via
logical_size. Release binaries are unchanged — test-only fix plus a 0.6.1 → 0.6.2 version bump.