python3: keep the order of patches and configure args stable - #3378
Open
f321x wants to merge 2 commits into
Open
python3: keep the order of patches and configure args stable#3378f321x wants to merge 2 commits into
f321x wants to merge 2 commits into
Conversation
`patches` and `configure_args` are deduplicated with `list(set(...))`, whose order depends on PYTHONHASHSEED. The configure arguments end up in the shipped `_sysconfigdata` module (CONFIG_ARGS), so two otherwise identical builds can differ, and the patches are applied in a different order on every run. Use an order-preserving dedup instead to help with reproducible builds. Upstreamed from https://github.com/spesmilo/python-for-android
T-Dynamos
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patchesandconfigure_argsare deduplicated withlist(set(...)),whose order depends on PYTHONHASHSEED.
The configure arguments end up in the shipped
_sysconfigdatamodule (CONFIG_ARGS), so two otherwise identical builds can differ,
and the patches are applied in a different order on every run.
Use an order-preserving dedup instead to help with reproducible builds.
Upstreamed from https://github.com/spesmilo/python-for-android