Skip to content

Fix non-contant format string err in go 1.26 #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
Sep 18, 2026
+4 −4
Merged

Fix non-contant format string err in go 1.26 #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/apis/bindings/v1alpha1/githubbinding_lifecycle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func (sbs *GitHubBindingStatus) InitializeConditions() {
// MarkBindingUnavailable marks the GitHubBinding's Ready condition to False with
// the provided reason and message.
func (sbs *GitHubBindingStatus) MarkBindingUnavailable(reason, message string) {
sbCondSet.Manage(sbs).MarkFalse(GitHubBindingConditionReady, reason, message)
sbCondSet.Manage(sbs).MarkFalse(GitHubBindingConditionReady, reason, "%s", message)
}

// MarkBindingAvailable marks the GitHubBinding's Ready condition to True.
Expand Down
6 changes: 3 additions & 3 deletions pkg/reconciler/source/githubsource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, source *sourcesv1alpha1.

ksvc, err := r.reconcileReceiveAdapter(ctx, source)
if err != nil {
source.Status.MarkWebhookNotConfigured("MissingReceiveAdapter", err.Error())
source.Status.MarkWebhookNotConfigured("MissingReceiveAdapter", "%s", err)
return err
}

Expand All @@ -147,14 +147,14 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, source *sourcesv1alpha1.
if source.Status.WebhookIDKey == "" {
hookID, err := r.createWebhook(ctx, args)
if err != nil {
source.Status.MarkWebhookNotConfigured("CreationFailed", err.Error())
source.Status.MarkWebhookNotConfigured("CreationFailed", "%s", err)
return err
}
source.Status.WebhookIDKey = hookID
} else {
err := r.reconcileWebhook(ctx, args, source.Status.WebhookIDKey)
if err != nil {
source.Status.MarkWebhookNotConfigured("ReconciliationFailed", err.Error())
source.Status.MarkWebhookNotConfigured("ReconciliationFailed", "%s", err)
return err
}
}
Expand Down
Loading