test: record deployer on deploy redeploys - #4008
Merged
Merged
Conversation
set explicitly mock deployer so that we persist on tests that re-deploy. This is needed because now empty deployer without the Deploy.Deployer set would default to knative through legacy-deployer path.
knative-prow
Bot
added
the
approved
knative-prow
Bot
added
the
size/M
gauron99
requested review from
lkingland and
matejvasek
and removed request for
dsimansk and
jrangelramos
August 14, 2026 10:29
Contributor
Author
|
/retest |
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set explicitly mock deployer so that we persist on tests that re-deploy. This is needed because now empty deployer without the Deploy.Deployer set would default to knative through legacy-deployer path.